search

mainmatter / ember-test-selectors

Enabling better element selectors in Ember.js tests
MIT License
262 stars 41 forks source link

Add support for `ember-cli-babel` v8 #1213

Closed bertdeblock closed 10 months ago

bertdeblock commented 1 year ago

Builds on #1212.

Closes #1211.

jrjohnson commented 11 months ago

@marcoow or @Turbo87 (the last two non renovate commiters here). Can someone take a look at this? With ember-cli-babel v8 in the default blueprint this change is very much needed.

marcoow commented 11 months ago

@bertdeblock can you rebase on #1212?

bertdeblock commented 10 months ago

@marcoow Rebased.

marcoow commented 10 months ago

@bertdeblock tests fail with latest Ember versions…

bertdeblock commented 10 months ago

That's already the case on master, so unrelated to this PR AFAICT. Seems like the dummy app needs a bit of maintenance.

marcoow commented 10 months ago

ah I see

Windvis commented 7 months ago

@marcoow Is there any chance we can get a new release that includes this change? 🙏

bertdeblock commented 6 months ago

https://github.com/mainmatter/ember-test-selectors/pull/1216 fixes CI, can someone cut a release?

gorner commented 2 months ago

@bertdeblock @marcoow any updates on a new release? I see #1216 was closed without merging but I'm not sure why.

bertdeblock commented 2 months ago

Nope, I don't maintain this library. I closed that PR because I didn't want to wait anymore, and I don't use this library anymore.