search

mainmatter / mainmatter.com

The source code for https://mainmatter.com
16 stars 9 forks source link

Add Luca's Panel from Rust for the Web Barcelona #2472

Closed IdeliaRisella closed 2 months ago

IdeliaRisella commented 4 months ago

To do: add thumbnail

IdeliaRisella commented 2 months ago

@marcoow I tried changing the thumbnail on this PR, as well as another one, and it seems like it's not quiet right as the checks were not successful. I tried doing what Emma explained to me before. I am not sure where exactly I missed. Would you please help and explain to me what I need to pay attention to so I can work on the rest of the thumbnail, or maybe I should go to Xenia to help me learn more?

marcoow commented 2 months ago

There was a lint error (I fixed) and the branch was branched off of an old ref which lead to the visual changes reported by Percy. Bart or Gabor should have some time maybe to explain in more detail.

The Netlify error was random and unrelated to your changes…

marcoow commented 2 months ago

let's make sure we get these things on the website a bit quicker after the events have occurred in the future :pray:

IdeliaRisella commented 2 months ago

Hi Marco,

I just want to let you know that there is another open PR made by Emma that hasn't been merged yet. I think the same problem happened like this one. The PR was undone because the new thumbnail was not available in July, and I seemed to have lost track of this task. But I'm planning to get this done this week, as well as changing all the thumbnails. I'll contact Bart or Gabor for further explanation, thank you again.

Best regards, Idelia Risella

On Wed, Sep 11, 2024 at 4:51 PM Marco Otte-Witte @.***> wrote:

let's make sure we get these things on the website a bit quicker after the events have occurred in the future 🙏

— Reply to this email directly, view it on GitHub https://github.com/mainmatter/mainmatter.com/pull/2472#issuecomment-2343902732, or unsubscribe https://github.com/notifications/unsubscribe-auth/BJI5TZ7GSZVO37EU5MFJJNLZWBKHRAVCNFSM6AAAAABJ5XFMMOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBTHEYDENZTGI . You are receiving this because you authored the thread.Message ID: @.***>