search

mainmatter / qunit-dom-codemod

Basic codemod to automatically convert your assertions to qunit-dom assertions
MIT License
14 stars 13 forks source link

codemod fails with complaint about a missing semicolon #235

Open jagthedrummer opened 3 months ago

jagthedrummer commented 3 months ago 
$ ember-cli-update --run-codemods
? Which blueprint would you like to run codemods for? ember-cli
? These codemods apply to your project. Select which ones to run. qunit-dom-codemod
Running codemod qunit-dom-codemod
Running command 1 of 1
Processing 305 files...
Spawning 9 workers...
Sending 34 files to free worker...
Sending 34 files to free worker...
Sending 34 files to free worker...
Sending 34 files to free worker...
Sending 34 files to free worker...
Sending 34 files to free worker...
Sending 34 files to free worker...
Sending 34 files to free worker...
Sending 33 files to free worker...
/Users/jgreen/.asdf/installs/nodejs/18.15.0/lib/node_modules/jscodeshift/node_modules/@babel/core/lib/parser/index.js:74
    throw err;
    ^

SyntaxError: /private/var/folders/fx/vmqbtyws34j1l88m16_9jy_00000gn/T/jscodeshift2024221-43095-1opgsb5.djbe.js: Missing semicolon. (1:3)

> 1 | 404: Not Found
    |    ^
    at constructor (/Users/jgreen/.asdf/installs/nodejs/18.15.0/lib/node_modules/jscodeshift/node_modules/@babel/parser/lib/index.js:353:19)
    at FlowParserMixin.raise (/Users/jgreen/.asdf/installs/nodejs/18.15.0/lib/node_modules/jscodeshift/node_modules/@babel/parser/lib/index.js:3277:19)
    at FlowParserMixin.semicolon (/Users/jgreen/.asdf/installs/nodejs/18.15.0/lib/node_modules/jscodeshift/node_modules/@babel/parser/lib/index.js:3598:10)
    at FlowParserMixin.parseExpressionStatement (/Users/jgreen/.asdf/installs/nodejs/18.15.0/lib/node_modules/jscodeshift/node_modules/@babel/parser/lib/index.js:12765:10)
    at FlowParserMixin.parseExpressionStatement (/Users/jgreen/.asdf/installs/nodejs/18.15.0/lib/node_modules/jscodeshift/node_modules/@babel/parser/lib/index.js:5077:18)
    at FlowParserMixin.parseStatementContent (/Users/jgreen/.asdf/installs/nodejs/18.15.0/lib/node_modules/jscodeshift/node_modules/@babel/parser/lib/index.js:12376:19)
    at FlowParserMixin.parseStatementLike (/Users/jgreen/.asdf/installs/nodejs/18.15.0/lib/node_modules/jscodeshift/node_modules/@babel/parser/lib/index.js:12239:17)
    at FlowParserMixin.parseStatementLike (/Users/jgreen/.asdf/installs/nodejs/18.15.0/lib/node_modules/jscodeshift/node_modules/@babel/parser/lib/index.js:5055:24)
    at FlowParserMixin.parseModuleItem (/Users/jgreen/.asdf/installs/nodejs/18.15.0/lib/node_modules/jscodeshift/node_modules/@babel/parser/lib/index.js:12216:17)
    at FlowParserMixin.parseBlockOrModuleBlockBody (/Users/jgreen/.asdf/installs/nodejs/18.15.0/lib/node_modules/jscodeshift/node_modules/@babel/parser/lib/index.js:12796:36)
    at FlowParserMixin.parseBlockBody (/Users/jgreen/.asdf/installs/nodejs/18.15.0/lib/node_modules/jscodeshift/node_modules/@babel/parser/lib/index.js:12789:10)
    at FlowParserMixin.parseProgram (/Users/jgreen/.asdf/installs/nodejs/18.15.0/lib/node_modules/jscodeshift/node_modules/@babel/parser/lib/index.js:12116:10)
    at FlowParserMixin.parseTopLevel (/Users/jgreen/.asdf/installs/nodejs/18.15.0/lib/node_modules/jscodeshift/node_modules/@babel/parser/lib/index.js:12106:25)
    at FlowParserMixin.parseTopLevel (/Users/jgreen/.asdf/installs/nodejs/18.15.0/lib/node_modules/jscodeshift/node_modules/@babel/parser/lib/index.js:5822:28)
    at FlowParserMixin.parse (/Users/jgreen/.asdf/installs/nodejs/18.15.0/lib/node_modules/jscodeshift/node_modules/@babel/parser/lib/index.js:13905:10)
    at parse (/Users/jgreen/.asdf/installs/nodejs/18.15.0/lib/node_modules/jscodeshift/node_modules/@babel/parser/lib/index.js:13947:38)
    at parser (/Users/jgreen/.asdf/installs/nodejs/18.15.0/lib/node_modules/jscodeshift/node_modules/@babel/core/lib/parser/index.js:41:34)
    at parser.next (<anonymous>)
    at normalizeFile (/Users/jgreen/.asdf/installs/nodejs/18.15.0/lib/node_modules/jscodeshift/node_modules/@babel/core/lib/transformation/normalize-file.js:64:37)
    at normalizeFile.next (<anonymous>)
    at run (/Users/jgreen/.asdf/installs/nodejs/18.15.0/lib/node_modules/jscodeshift/node_modules/@babel/core/lib/transformation/index.js:21:50)
    at run.next (<anonymous>)
    at transform (/Users/jgreen/.asdf/installs/nodejs/18.15.0/lib/node_modules/jscodeshift/node_modules/@babel/core/lib/transform.js:22:33)
    at transform.next (<anonymous>)
    at evaluateSync (/Users/jgreen/.asdf/installs/nodejs/18.15.0/lib/node_modules/jscodeshift/node_modules/gensync/index.js:251:28)
    at sync (/Users/jgreen/.asdf/installs/nodejs/18.15.0/lib/node_modules/jscodeshift/node_modules/gensync/index.js:89:14)
    at stopHiding - secret - don't use this - v1 (/Users/jgreen/.asdf/installs/nodejs/18.15.0/lib/node_modules/jscodeshift/node_modules/@babel/core/lib/errors/rewrite-stack-trace.js:47:12)
    at Object.transformSync (/Users/jgreen/.asdf/installs/nodejs/18.15.0/lib/node_modules/jscodeshift/node_modules/@babel/core/lib/transform.js:42:76)
    at exports.transformSync (/Users/jgreen/.asdf/installs/nodejs/18.15.0/lib/node_modules/jscodeshift/node_modules/@babel/register/lib/worker/transform.js:81:15)
    at LocalClient.handleMessage (/Users/jgreen/.asdf/installs/nodejs/18.15.0/lib/node_modules/jscodeshift/node_modules/@babel/register/lib/worker/handle-message.js:18:16)
    at LocalClient.<anonymous> (/Users/jgreen/.asdf/installs/nodejs/18.15.0/lib/node_modules/jscodeshift/node_modules/@babel/register/lib/worker-client.js:97:86)
    at LocalClient.transform (/Users/jgreen/.asdf/installs/nodejs/18.15.0/lib/node_modules/jscodeshift/node_modules/@babel/register/lib/worker-client.js:42:47)
    at compile (/Users/jgreen/.asdf/installs/nodejs/18.15.0/lib/node_modules/jscodeshift/node_modules/@babel/register/lib/hook.js:46:25)
    at compileBabel7 (/Users/jgreen/.asdf/installs/nodejs/18.15.0/lib/node_modules/jscodeshift/node_modules/@babel/register/lib/hook.js:38:14)
    at Module._compile (/Users/jgreen/.asdf/installs/nodejs/18.15.0/lib/node_modules/jscodeshift/node_modules/pirates/lib/index.js:113:29)
    at Module._extensions..js (node:internal/modules/cjs/loader:1308:10)
    at Object.newLoader [as .js] (/Users/jgreen/.asdf/installs/nodejs/18.15.0/lib/node_modules/jscodeshift/node_modules/pirates/lib/index.js:121:7)
    at Module.load (node:internal/modules/cjs/loader:1117:32)
    at Module._load (node:internal/modules/cjs/loader:958:12)
    at Module.require (node:internal/modules/cjs/loader:1141:19)
    at require (node:internal/modules/cjs/helpers:110:18)
    at setup (/Users/jgreen/.asdf/installs/nodejs/18.15.0/lib/node_modules/jscodeshift/src/Worker.js:93:18)
    at Object.<anonymous> (/Users/jgreen/.asdf/installs/nodejs/18.15.0/lib/node_modules/jscodeshift/src/Worker.js:45:3)
    at Module._compile (node:internal/modules/cjs/loader:1254:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1308:10)
    at Module.load (node:internal/modules/cjs/loader:1117:32)
    at Module._load (node:internal/modules/cjs/loader:958:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
    at node:internal/main/run_main_module:23:47 {
  code: 'BABEL_PARSE_ERROR',
  reasonCode: 'MissingSemicolon',
  loc: Position { line: 1, column: 3, index: 3 },
  pos: 3
}
darrenw-npi commented 2 months ago

I get this too and I have tried with Node 14,16,18 and 20

darrenw-npi commented 2 months ago

Update: I was getting this when running it from ember-cli-update --run-codemods however if I use the installation and usage instructions from the readme in this repo it seems to work. So:

npm install -g jscodeshift
jscodeshift -t https://raw.githubusercontent.com/Mainmatter/qunit-dom-codemod/master/qunit-dom-codemod.js ./tests

I did this using Node v20.12.2