search

mainmatter / qunit-dom

High Level DOM Assertions for QUnit
MIT License
178 stars 123 forks source link

Does it makes sense to add vanilla / vanillajs to this project's tags? #2059

Open NullVoxPopuli opened 11 months ago

NullVoxPopuli commented 11 months ago

Just looking here: image

the first tags are ember/emberjs.

But with the v3 release candidate (and higher), ember is no longer really relevant to use qunit-dom (it doesn't need to be).

support for ember isn't even really a thing. (aside from this id here: https://github.com/mainmatter/qunit-dom/blob/d765ecf34477cc3466f0a69267bf35015f4b377e/packages/qunit-dom/lib/qunit-dom-modules.ts#L16 -- but that could probably be made configurable )

qunit-dom now works with anything, in any environment :sparkles:

(JSBin example here: https://jsbin.com/fipayiy/edit?html,output )

BobrImperator commented 5 months ago

I think it makes sense, in fact when used as a module and not iffe, a getRootElement function can be provided already.