mainsail-crew / MainsailOS

This Raspberry Pi distribution for managing Klipper 3D printers with Mainsail provides all you need.
https://docs.mainsail.xyz/setup/mainsail-os
GNU General Public License v3.0
554 stars 273 forks source link

Logrotation config files might be writable by group #170

Closed miklschmidt closed 1 year ago

miklschmidt commented 2 years ago

What happened

So i don't know if this applies to you guys, but the logrotation configs supplied by the mainsail module ended up being 664 instead of 644 in the image, so logrotate would ignore those and the logs would just pile up.

What did you expect to happen

Logrotation.d files should be chmodded to 644 (i'm doing this in the start_chroot_script now).

How to reproduce

sudo /usr/sbin/logrotate /etc/logrotate.conf ls -la /etc/logrotation.d

Additional information

This might very well be a RatOS only issue, but i just wanted to keep you guys posted in case it carried over from MainsailOS. Feel free to close!

miklschmidt commented 2 years ago

See https://github.com/Rat-OS/RatOS/issues/39

KwadFan commented 1 year ago

Hey @miklschmidt ,

Will do some tests at the weekend, may an issue due how Custompios copies files. In the source the files are as expected 0644 ... :man_shrugging:

KwadFan commented 1 year ago

Hey @miklschmidt ,

Made some tests. Short tests but they work. @zellneralex is doing a Longterm Test right now, will report results. Bildschirmfoto_2022-11-23_08-59-09 Bildschirmfoto_2022-11-23_08-57-47

Regards Kwad

miklschmidt commented 1 year ago

Well the permissions look fine, so the problem i had shouldn't be present at least :)

KwadFan commented 1 year ago

@miklschmidt

Could you reproduce that with 1.0.0 ?

KwadFan commented 1 year ago

Closing issue due no further interaction and not reproducable since new release.

miklschmidt commented 1 year ago

Closing issue due no further interaction and not reproducable since new release.

Sorry i forgot to get back to you on this, everything looks good on my end, so closing is appropriate 👍