mainsail-crew / MainsailOS

This Raspberry Pi distribution for managing Klipper 3D printers with Mainsail provides all you need.
https://docs.mainsail.xyz/setup/mainsail-os
GNU General Public License v3.0
524 stars 250 forks source link

Orangepizero3 support #249

Open meganukebmp opened 8 months ago

meganukebmp commented 8 months ago

Since @meteyou already added the device and it built fine in armbian-builds, this should probably get us support for this board.

Unfortunately I am unable to build the workflows and see if it actually works correctly.

KwadFan commented 8 months ago

Well, I already see a design flaw in this PR. Images without a boot partition will not work, because you need it to configure the network. There is no way to connect before hand. Also moving partition layout out of the default file will also lead to issues if we build more than those 2 Images.

The orangepi_net module is used to provide network setup funtkionality which uses the fat partition. I cant test the base Image from the PR https://github.com/mainsail-crew/armbian-builds/pull/37, because I thought the Image would be correct as I aproved it. As said cant test, so I heavily relie on your feedback.

Is there no fat partition on that particular Image?

KwadFan commented 8 months ago

Verified it already, this Image has no FAT32 boot partition, therefore it wont work with that build chain.

We need to address this in armbian-builds.

On the base images you can setup everything on first boot. This "mechanic" doesnt exist in MainsailOS! So, we need to fix the base image first.

meteyou commented 8 months ago

i will doublecheck the orangepi settings. maybe i overview something there...

meganukebmp commented 8 months ago

It appears your armbian builds do have a boot partition! And it works too, which is because the armbian build system overrides the boot scripts. However, the boot partition is not accessible under windows because it gets created of type Linux extended boot rather than Win95 FAT. I'm not sure why.

If I modify the disk partitions after building it it and change type from Linux extended boot to Win95 FAT it ends up working on windows just fine. image

Do any other boards exhibit this behavior?

meganukebmp commented 8 months ago

This last patch would allow for the builds to succeed. However the boot partition is labeled in such a way that windows cannot see it. Windows is fully capable of reading these partitions normally, it's just labeled as Linux extended boot rather than Win95 FAT Which prevents windows from assigning it a drive letter.

meteyou commented 8 months ago

hmm... its funny, because it should be the same as the zero2 image, but it is different...

meganukebmp commented 8 months ago

Actually the zero2 image ends up identical... It's partition type 0xEA, aka linux extended boot. And fails to mount on windows. To test this I even flashed the zero2 image to an sdcard.

image

234 = 0xEA

meteyou commented 8 months ago

ok. then it looks like kwad tested it wrong the last time. i have to doublecheck the complete workflow of orangepi again. looks like a generic issue in this workflow and the filesystem.

Thx for all your work!

KwadFan commented 8 months ago

So, I did some test with images resulting from this PR: https://github.com/mainsail-crew/armbian-builds/pull/37

Images can be found here: https://github.com/mainsail-crew/armbian-builds/actions/runs/6631552667

The resulting images show the correct FAT partition. Bildschirmfoto_2023-11-01_14-20-45

But... I cant test it on real hardware, due missing the Zero3, Zero2 is working as expected. Also I cant test how the resulting SDCard looks under Windows because I use Linux as daily driver :man_shrugging:

VectorForce3D commented 6 months ago

So, I did some test with images resulting from this PR: mainsail-crew/armbian-builds#37

Images can be found here: https://github.com/mainsail-crew/armbian-builds/actions/runs/6631552667

The resulting images show the correct FAT partition. Bildschirmfoto_2023-11-01_14-20-45

But... I cant test it on real hardware, due missing the Zero3, Zero2 is working as expected. Also I cant test how the resulting SDCard looks under Windows because I use Linux as daily driver 🤷‍♂️

I own all of the hardware necessary to test this. If I can be of service, I would be more than happy to test this build.

SkAntRu commented 4 months ago

Hi, i can test it on OPi Zero3 1.5Gb and I very interested in adding support for it!
Actions with images https://github.com/mainsail-crew/armbian-builds/actions/runs/6631552667 expired, can you rerun it?