mainsail-crew / MainsailOS

This Raspberry Pi distribution for managing Klipper 3D printers with Mainsail provides all you need.
https://docs.mainsail.xyz/setup/mainsail-os
GNU General Public License v3.0
546 stars 262 forks source link

fix(build): fix log file upload #297

Closed KwadFan closed 4 months ago

KwadFan commented 4 months ago

As seen in this example run: https://github.com/mainsail-crew/MainsailOS/actions/runs/8959578689 , an error occurs during the phase to upload the build log.

The issue is introduced due the failing Rename Image step. Because, if the build fails there is no according image to rename, which results in an empty IMAGEenvironment variable. This leads to an incorrect renamed log file and also duplicates failing steps which should not executed if build fails. Bildschirmfoto_2024-05-24_23-33-44

Therefor changing the order of steps, triggers and naming of log file.