search

mainsail-crew / mainsail

Mainsail is the popular web interface for managing and controlling 3D printers with Klipper.
https://docs.mainsail.xyz
GNU General Public License v3.0
1.71k stars 365 forks source link

Update OverlayScrollbars to v2 #1262

Open KingSora opened 1 year ago

KingSora commented 1 year ago

Requested feature:

Currently mainsail uses v1 of OverlayScrollbars. v2 was released recently and has a lot of improvements compared to v2. (Focus on modern browsers, 50% smaller size, treeshaking, deferred initialization and many more). A full list of features and changes can be found here.

Solves the following problem:

No response

Additional information:

No response

meteyou commented 1 year ago

@KingSora thx for your FR. I have now checked overlayscrollbars and wanted to update it. But overlayscrollbars-vue is only compatible with vue3 since v0.3.0. Currently, Mainsail still uses vue2. Am I missing something?

KingSora commented 1 year ago

@meteyou the newest overlayscrollbars-vue package is indeed only compatible with vue3. But since all the framework wrappers (vue, react etc.) are just tiny wrappers around the original library there can also be a vue2 version for it. I could write something like that if youre interested

meteyou commented 1 year ago

@KingSora a small example would be nice! thx!