search

mainsail-crew / mainsail

Mainsail is the popular web interface for managing and controlling 3D printers with Klipper.
https://docs.mainsail.xyz
GNU General Public License v3.0
1.69k stars 353 forks source link

refactor(macros): refactor gcode_macros getter #1889

Closed meteyou closed 3 months ago

meteyou commented 4 months ago

Description

This PR refactor the gcode_macros getter to use the printer state objects instead of the configfile objects.

Related Tickets & Documents

Discussion with @Frix-x on discord: https://discord.com/channels/758059413700345988/901024829875027998/1242042001248096328

Mobile & Desktop Screenshots/Recordings

none

[optional] Are there any post-deployment tasks we need to perform?

none

Frix-x commented 4 months ago

Hello, thanks for this PR!

I can confirm that it solve the issue I had on my side and the macro pannel doesn't crash anymore :)