search

mainsail-crew / mainsail

Mainsail is the popular web interface for managing and controlling 3D printers with Klipper.
https://docs.mainsail.xyz
GNU General Public License v3.0
1.68k stars 349 forks source link

feat: adds a file structure sidebar in the editor #1943

Closed CF3B5 closed 5 days ago

CF3B5 commented 2 months ago

Description

The configuration file is too long, so I did this feature, clicking on the structure tree item will jump to the number of file lines.

Related Tickets & Documents

none.

Mobile & Desktop Screenshots/Recordings

Voron-2-4 the sidebar is hidden on mobile screen.

[optional] Are there any post-deployment tasks we need to perform?

none.

Signed-off-by: cf3b5 cf3b5bb@gmail.com

github-actions[bot] commented 2 months ago
Language file analysis report: File Missing Keys Unused Keys
en.json 2 0
zh.json 13 1
github-actions[bot] commented 2 months ago
Language file analysis report: File Missing Keys Unused Keys
en.json 0 0
zh.json 13 1
github-actions[bot] commented 2 months ago
Language file analysis report: File Missing Keys Unused Keys
en.json 0 0
zh.json 13 1
meteyou commented 2 months ago

thanks for the PR! i'm looking forward to testing it. if you need any help or information from me about the prettier test, feel free to ping me!

github-actions[bot] commented 2 months ago
Language file analysis report: File Missing Keys Unused Keys
en.json 0 0
zh.json 13 1
CF3B5 commented 2 months ago

thanks for the PR! i'm looking forward to testing it. if you need any help or information from me about the prettier test, feel free to ping me!

I try my best. Why do I always fail the prettier test. :-(

meteyou commented 2 months ago

@CF3B5 just try to run npm run format and commit & push the changes...

meteyou commented 2 months ago

This PR should also fix #1320

github-actions[bot] commented 2 months ago
Language file analysis report: File Missing Keys Unused Keys
en.json 0 0
zh.json 13 1
meteyou commented 1 month ago

Many thanks for this PR! I really love this function!

I just have one small suggestion for improvement. Would it be possible to jump to the section when clicking on the name and only open/close the attributes when clicking on the triangle?

github-actions[bot] commented 1 month ago
Language file analysis report: File Missing Keys Unused Keys
en.json 0 0
zh.json 13 1
CF3B5 commented 1 month ago

Many thanks for this PR! I really love this function!

I just have one small suggestion for improvement. Would it be possible to jump to the section when clicking on the name and only open/close the attributes when clicking on the triangle?

ok, I've changed. thank you for liking this feature :-)

github-actions[bot] commented 1 month ago
Language file analysis report: File Missing Keys Unused Keys
en.json 0 0
zh.json 13 1
github-actions[bot] commented 1 month ago
Language file analysis report: File Missing Keys Unused Keys
en.json 0 0
zh.json 13 1
github-actions[bot] commented 1 month ago
Language file analysis report: File Missing Keys Unused Keys
en.json 0 0
zh.json 13 1
github-actions[bot] commented 5 days ago
Language file analysis report: File Missing Keys Unused Keys
en.json 0 0
zh.json 8 0
github-actions[bot] commented 5 days ago
Language file analysis report: File Missing Keys Unused Keys
en.json 0 0
zh.json 8 0
github-actions[bot] commented 5 days ago
Language file analysis report: File Missing Keys Unused Keys
en.json 0 0
zh.json 8 0
github-actions[bot] commented 5 days ago
Language file analysis report: File Missing Keys Unused Keys
en.json 0 0
zh.json 8 0
meteyou commented 5 days ago

@CF3B5 thanks for your PR!

i just fixed some visual issues in the treeview and refactored some code blocks.