Open miklschmidt opened 2 months ago
Thx for creating the FR.
pls also open a second FR with this feature:
In the future (not a requirement , just extra "icing on the cake" so to speak, the existing functionality already accounts for a vast array of use cases), it could even allow multiple entries, alas that would require changes to the mainsail klipper macros, so i suggest tabling that for now.
Just when I merge the PR for this FR, this information will be "lost", because the ticket is closed.
@meteyou done! #1945
This is Xulkal on the RatRig discord. I'm available if you need someone to test out these features before landing. Depending on my schedule, I might try implementing this and putting up a pr for review, but not holding my breath this week due to family matters.
hey @XScorpion2!
at the moment i have to finish 2-3 things before i can start with this FR. so i probably won't get to these FR until next week. If you are interested, you are welcome to contribute this FR. i would be very happy about it!
Requested feature:
Since the macro used for this feature supports custom gcode macros, it would be ideal if the dialog allowed the user to input a custom macro / gcode command instead of only picking between
M600
andPAUSE
.This could either be achieved by changing the select box to a combobox/autocomplete which accepts custom text input and suggests
M600
/PAUSE
by default, or by adding a "Custom" option and showing a text input based on the selection of that item.Solves the following problem:
Additional information:
The idea is to provide ample opportunity for the user to "save a print" if he forgets to add these during slicing, or is printing the same sliced file but needs an escape hatch at a certain layer.
In the future (not a requirement , just extra "icing on the cake" so to speak, the existing functionality already accounts for a vast array of use cases), it could even allow multiple entries, alas that would require changes to the mainsail klipper macros, so i suggest tabling that for now. Added #1945 to track this separately.