search

mainsail-crew / mainsail

Mainsail is the popular web interface for managing and controlling 3D printers with Klipper.
https://docs.mainsail.xyz
GNU General Public License v3.0
1.68k stars 349 forks source link

Driver OTPW cannot be cleared or ignored #1955

Open miklschmidt opened 1 month ago

miklschmidt commented 1 month ago

Mainsail Version:

2.12.0

Browser:

Chrome

Device:

Desktop PC

Operating System:

Windows

What happened?

A lot of buttons that do nothing. This seems unintentional.

https://github.com/user-attachments/assets/aa1bc50c-e689-40c8-acd8-275cacc8ab90

It would be nice if they worked. Currently you cannot avoid this warning if you want to get the maximum out of a set of 2209 sticks for example, and as such this is just an annoyance and not very helpful.

What did you expect to happen instead?

The notification to be dismissed / ignored, or worst case scenario that the buttons were disabled.

How to reproduce this bug?

Either generate the OTPW flag on a driver, or just unconditionally push it to the notification list in the client code since it's a mainsail-only implementation.

Additional information:

No response

sbtoonz commented 1 month ago

image appears to still be present in 2.12 release

meteyou commented 1 month ago

@sbtoonz pls post a video...

sbtoonz commented 1 month ago

https://github.com/user-attachments/assets/fbe7265b-f830-46c4-8c6a-647f137113eb

meteyou commented 1 month ago

@sbtoonz pls try a reload without cache (ctrl + shift + f5 on windows)

sbtoonz commented 1 month ago

https://github.com/user-attachments/assets/bf8e54c5-9d9a-4297-af05-8772e738af71

sbtoonz commented 1 month ago

force cache reload not yielding any different outcome

meteyou commented 1 month ago

ohhh... @sbtoonz pls check the PR for this bug itself. this one is not even merged yet (waiting for a review) and therefore not yet released!

(and the initial bug report also describe, that this issue is in v2.12.0)

sbtoonz commented 1 month ago

Ah I'll pull this down then :)

meteyou commented 1 month ago

You can download a build from the ci chain.