mainsail-crew / mainsail

Mainsail is the popular web interface for managing and controlling 3D printers with Klipper.
https://docs.mainsail.xyz
GNU General Public License v3.0
1.71k stars 363 forks source link

feat: added second layer confirmation for Cancel Job #1978

Closed FatalBulletHit closed 1 month ago

FatalBulletHit commented 2 months ago

Description

This PR adds a second layer confirmation dialog for the Cancel Job button.

Related Tickets & Documents

None.

Mobile & Desktop Screenshots/Recordings

image

github-actions[bot] commented 2 months ago
Language file analysis report: File Missing Keys Unused Keys
de.json 0 0
en.json 0 0
github-actions[bot] commented 2 months ago
Language file analysis report: File Missing Keys Unused Keys
de.json 0 0
en.json 0 0
github-actions[bot] commented 2 months ago
Language file analysis report: File Missing Keys Unused Keys
de.json 0 0
en.json 0 0
github-actions[bot] commented 2 months ago
Language file analysis report: File Missing Keys Unused Keys
de.json 0 0
en.json 0 0
meteyou commented 2 months ago

Thx for your PR!

its fine, that you only add languages, which you are know/speak. all other languages should be translated by the translators. (missing translations are better then wrong translations, because the translators will find them faster).

you don't need docker for testing it. you just have to:

then you should be able to test it.

please change the toolbar from red to normal. the e-stop dialog is the only one that has this toolbar color. every other confirm dialog does not have this.

furthermore, i am still thinking about how useful this dialog is, because it is actually a third level confirm (pause -> cancel -> dialog). but it is optional, and there are users who deactivate the pause -> cancel, so it could be useful especially for these users.

github-actions[bot] commented 2 months ago
Language file analysis report: File Missing Keys Unused Keys
de.json 0 0
en.json 0 0
github-actions[bot] commented 2 months ago
Language file analysis report: File Missing Keys Unused Keys
de.json 0 0
en.json 0 0
FatalBulletHit commented 2 months ago

Fixed, tested and working, thanks for the help! Will use this with the "always display cancel print" option and hopefully not accidentally cancel prints anymore. 😄 image

meteyou commented 2 months ago

pls also change the icon from the dialog. this one looks like a "loading issue" from the icon.

FatalBulletHit commented 2 months ago

How about mdiStopCircleOutline? Or would you prefer another one or no icon at all? image

github-actions[bot] commented 2 months ago
Language file analysis report: File Missing Keys Unused Keys
de.json 0 0
en.json 0 0
github-actions[bot] commented 1 month ago
Language file analysis report: File Missing Keys Unused Keys
de.json 2 0
en.json 0 0
github-actions[bot] commented 1 month ago
Language file analysis report: File Missing Keys Unused Keys
de.json 2 0
en.json 0 0