Closed FatalBulletHit closed 1 month ago
Language file analysis report: | File | Missing Keys | Unused Keys |
---|---|---|---|
de.json | 0 | 0 | |
en.json | 0 | 0 |
Language file analysis report: | File | Missing Keys | Unused Keys |
---|---|---|---|
de.json | 0 | 0 | |
en.json | 0 | 0 |
Language file analysis report: | File | Missing Keys | Unused Keys |
---|---|---|---|
de.json | 0 | 0 | |
en.json | 0 | 0 |
Language file analysis report: | File | Missing Keys | Unused Keys |
---|---|---|---|
de.json | 0 | 0 | |
en.json | 0 | 0 |
Thx for your PR!
its fine, that you only add languages, which you are know/speak. all other languages should be translated by the translators. (missing translations are better then wrong translations, because the translators will find them faster).
you don't need docker for testing it. you just have to:
npm ci
http://localhost:8080
to the cors_domains
in your moonraker.conf
of your printernpm run serve
http://localhost:8080
then you should be able to test it.
please change the toolbar from red to normal. the e-stop dialog is the only one that has this toolbar color. every other confirm dialog does not have this.
furthermore, i am still thinking about how useful this dialog is, because it is actually a third level confirm (pause -> cancel -> dialog). but it is optional, and there are users who deactivate the pause -> cancel, so it could be useful especially for these users.
Language file analysis report: | File | Missing Keys | Unused Keys |
---|---|---|---|
de.json | 0 | 0 | |
en.json | 0 | 0 |
Language file analysis report: | File | Missing Keys | Unused Keys |
---|---|---|---|
de.json | 0 | 0 | |
en.json | 0 | 0 |
Fixed, tested and working, thanks for the help!
Will use this with the "always display cancel print" option and hopefully not accidentally cancel prints anymore. 😄
pls also change the icon from the dialog. this one looks like a "loading issue" from the icon.
How about mdiStopCircleOutline
? Or would you prefer another one or no icon at all?
Language file analysis report: | File | Missing Keys | Unused Keys |
---|---|---|---|
de.json | 0 | 0 | |
en.json | 0 | 0 |
Language file analysis report: | File | Missing Keys | Unused Keys |
---|---|---|---|
de.json | 2 | 0 | |
en.json | 0 | 0 |
Language file analysis report: | File | Missing Keys | Unused Keys |
---|---|---|---|
de.json | 2 | 0 | |
en.json | 0 | 0 |
Description
This PR adds a second layer confirmation dialog for the Cancel Job button.
Related Tickets & Documents
None.
Mobile & Desktop Screenshots/Recordings