search

mainsail-crew / mainsail

Mainsail is the popular web interface for managing and controlling 3D printers with Klipper.
https://docs.mainsail.xyz
GNU General Public License v3.0
1.72k stars 367 forks source link

[FR] User authentication #267

Open 3dhobbies opened 3 years ago

3dhobbies commented 3 years ago

Is your feature request related to a problem? Please describe. Not a bug or so, basically a security concern when logging in from external domain (internet). i have done a port forward to my specific printer, and cannot find a way to force the mainsailos to ask for login credentials.

Describe the solution you'd like A basic secure login screen. forcing a user to log into the mainsailos when logging on.

Describe alternatives you've considered Cannot find any other way of securing the mainsailos install on my pi

Additional context Add any other context or screenshots about the feature request here.

meteyou commented 3 years ago

please do not use port forwarding on your printer! no matter if mainsail, octoprint or anything else is running on the printer! none of these systems were ever built for such a use. please use a secure vpn connection to your network.

apparently, some kind of login has now been integrated into moonraker, so i can also integrate it into mainsail, but it is still not a solution to access the printer via the internet.

3dhobbies commented 3 years ago

Thank you kindly Stefan.

I am already using a secure VPN to my workshop. The added login would be to keep nosy employees at bay 😃

Sent from Samsung / Android

Willie Le Maitre IT DirectorThe Nerd Zone (Pty) Ltd P: (010)8805851M: 0820430170A: 117A Ouklip Rd, Wilropark, 1724 W: https://nerdzone.co.za E: @.***  Please do not print this email unless it is necessary. Every unprinted email helps the environment.

On Thu, 22 Apr 2021, 13:13 Stefan Dej, @.***> wrote:

please do not use port forwarding on your printer! no matter if mainsail, octoprint or anything else is running on the printer! none of these systems were ever built for such a use. please use a secure vpn connection to your network.

apparently, some kind of login has now been integrated into moonraker, so i can also integrate it into mainsail, but it is still not a solution to access the printer via the internet.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/meteyou/mainsail/issues/267#issuecomment-824749512, or unsubscribe https://github.com/notifications/unsubscribe-auth/AODGF3UHPBMXN5BBDOPFX33TKAAF5ANCNFSM43KFJIKQ .

JellevanKraaij commented 2 years ago

I love to see support for the moonraker authentication functionality as well, hope it gets implemented soon! Just switched from fluidd to mainsail, but the authentication is the only thing that I find really missing.

Thanks a lot!!

kubik369 commented 2 years ago

Does it make sense to reinvent the wheel instead of using something like basic auth in nginx? OP is saying that he could not find any other way, but this seems to fit the bill perfectly, since kiauh already sets nginx up and all :)

meteyou commented 2 years ago

moonraker authentication does have certain advantages. furthermore, it is also nicer integrated in the gui.

dohlin commented 2 years ago

Switched from Fluidd to Mainsail and this is about the only thing I'm greatly missing. Definitely a nice to have!

tfjield commented 2 years ago

Is it possible to use basic auth in nginx? I've tried it, but after I provide credentials and Mainsail loads, it can't connect to Moonraker.

rroethof commented 2 years ago

Currently using Fluidd in combo with moonraker and in this network any network listener without a form of authentication is not an option. Therefore support for the moonraker auth is a much wanted request here.

MabaKalox commented 1 year ago

@meteyou hi! How can I help adding this feature?

meteyou commented 1 year ago

@MabaKalox hey! It would be very nice if you had time to finish the implementation! I started the implementation months ago here: https://github.com/mainsail-crew/mainsail/pull/370, but i haven't time to finish it.

The PR draft is very, very, very old. Starting with a new fork is more uncomplicated than updating my old branch.

meteyou commented 1 year ago

ahh sry. this was my implementation: https://github.com/meteyou/mainsail-dev/tree/feature/authorization

the PR above was from another guy.

MabaKalox commented 1 year ago

@meteyou Thank you, I will take a look.

Robnex commented 1 year ago

Hi. what's the status of the authentification implementation?

midikeyboard commented 1 year ago

Hi. what's the status of the authentification implementation?

its open on the roadmap. i currently run mainsail behind nginx proxy with a access list to authenticate while having public access. if you need authentication this is the way to go (for now).

meteyou commented 1 year ago

@midikeyboard even if the authentication of Moonraker is integrated, this feature is NOT made for public access!!!