Bed meshes with spaces or other special characters not working

mainsail-crew / mainsail

Mainsail is the popular web interface for managing and controlling 3D printers with Klipper.

https://docs.mainsail.xyz

GNU General Public License v3.0

1.71k stars 365 forks source link

Bed meshes with spaces or other special characters not working #643

Closed Misterke closed 2 years ago

Misterke commented 2 years ago

Describe the bug:\ The bed mesh / Heightmap view of Mainsail allows renaming the active profile and loading existing profiles from the configuration, but as soon as the profile contains a space (which is possible to provide as in BED_MESH_PROFILE SAVE="PROFILE WITH SPACES"), these actions fail due to Mainsail not quoting the parameters of BED_MESH_PROFILE.

Expected behavior:\ Profile manipulation should also work for profiles with spaces in the name.

Misterke commented 2 years ago

Note also that once https://github.com/Klipper3d/klipper/pull/5222 would get merged, Mainsail could check the actual profiles as maintained in bed_mesh.py rather than those from the static config which don't reflect any changes that have not yet been saved using SAVE_CONFIG.

meteyou commented 2 years ago

fixed with this commit https://github.com/mainsail-crew/mainsail/commit/96b212e8dc86f58fef6edd02ff10fe7fe36da573