search

maintaina-com / components

A package for dealing with Horde components
https://www.horde.org/apps/components
GNU Lesser General Public License v2.1
0 stars 2 forks source link

Latest version dropped support for php7? #13

Open midahp opened 2 years ago

midahp commented 2 years ago

The latest version (7948127) uses for example readonly and final public const keywords that are not supported by php7. If this is intentional, I think it should be made clear in the composer.json/horde.yml.

ralflang commented 2 years ago

No, php7 support for tagged releases is going to be kept until PHP 7 EOL. The development branch gets transpiled down to PHP 7.4 for release. Please use the phar in the meanwhile if you need functionality not present in the latest tagged release.

https://horde-satis.maintaina.com/horde-components

The transpiling is not yet automated - a few more nights.

ralflang commented 2 years ago

It would be interesting to have your feedback on the transpiled PHP 7.4 branch and the 1.0.0-alpha5.php.7.4 tag. The workflow is ugly but after some improvement it should fit well into a pipeline. Composer should be able to automatically choose the best compatible build.

FRAMEWORK_6_0.php.7.4 FRAMEWORK_6_0.php.8.1

midahp commented 2 years ago

The PHP 7.4 branch works perfectly, thanks.

Installing the tag with composer does not work for me though:

>>> composer require horde/components 1.0.0-alpha5.php.7.4                                                                                                                

In VersionParser.php line 521:

  Could not parse version constraint 1.0.0-alpha5.php.7.4: Invalid version string "1.0.0-alpha5.php.7.4"

And:

>>> composer require horde/components 1.0.0-alpha5                                                                                                                     [1]
./composer.json has been updated
Running composer update horde/components
Loading composer repositories with package information
Updating dependencies
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - symfony/console 6.2.x-dev requires php >=8.1 -> your php version (7.4.30) does not satisfy that requirement.
    - friendsofphp/php-cs-fixer dev-master requires symfony/console ^5.4 || ^6.0 -> satisfiable by symfony/console[6.2.x-dev].
    - friendsofphp/php-cs-fixer is locked to version dev-master and an update of this package was not requested.

Use the option --with-all-dependencies (-W) to allow upgrades, downgrades and removals for packages currently locked to specific versions.

Installation failed, reverting ./composer.json and ./composer.lock to their original content.
ralflang commented 2 years ago

I see. Composer does not really implement SemVer v2. I will change the label to fit...