Fix openssl version check - Githubissues

mainwp / mainwp-child

The MainWP Child plugin is installed on the WordPress sites that you want to control from the MainWP Dashboard.

https://mainwp.com

GNU General Public License v3.0

93 stars 54 forks source link

Fix openssl version check #283

Closed mircobabini closed 2 years ago

mircobabini commented 2 years ago

All Submissions:

[x] Have you followed the MainWP Contributing guideline?
[x] Does your code follow the WordPress' coding standards?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

Fix for this reported request: https://wordpress.org/support/topic/false-positive-for-openssl-version/

This was happening because $openssl_version was a string instead of an array as expected from the curlssl check function.

The hex version of OpenSSL 1.1.0 is taken from the source code of the OpenSSL 1.1.0 tag release on github: https://github.com/openssl/openssl/releases/tag/OpenSSL_1_1_0

Other information:

[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Have you written new tests for your changes, as applicable?
[x] Have you successfully run tests with your changes locally?

thanghv commented 2 years ago

The issue fixed.