search

mainyaa / gulp-electron

A gulp plugin for atom-shell distribute applications
MIT License
124 stars 28 forks source link

can not replace exe file icon #24

Open Wolfspirit opened 9 years ago

Wolfspirit commented 9 years ago

I found an issue in index.js, this take me can not replace exe file icon. My gulp-electron version is 0.0.7. At line 263, the first judge is the same as line 257, so, i modified first judge at line 257 to 

(platform.indexOf('win32') >= 0 || platform.indexOf('win64') >= 0)

and repack my app, this issue corrected.

mainyaa commented 9 years ago

Thanks @Wolfspirit but.. Windows returns 'win32', even on 64 bit operation systems.

Wolfspirit commented 9 years ago

@mainyaa Yes, you are right. Thanks.

dmythro commented 8 years ago

At this point none of icons for win32/64 is replaced with one I set. Same path as for Mac except ext, like ./resources/icon.ico, but Mac is fine, Win fails to get a proper icon for a file.