search

maisano / react-router-transition

painless transitions built for react-router, powered by react-motion
http://maisano.github.io/react-router-transition/
MIT License
2.6k stars 138 forks source link

Support render for AnimatedRoute #106

Closed MichaelDimmitt closed 5 years ago

MichaelDimmitt commented 5 years ago

First, thanks for the package.

Thanks for the really useful package allowing transitions via routes and more!

The Fix

Simply added the render prop into the codebase. React Router uses a ternary to check for the render key if component key is not used.

The problem

The project I am putting this into does not use component in we instead use render

Non essential information related to the pr can be found here: https://github.com/dimmitt/non-essential-information-for-react-router-transition-pr/tree/master

MichaelDimmitt commented 5 years ago

While waiting on the pr I published the fix here: npm install --save react-router-transition-render-fork

Will un-publish when the change is merged.

MichaelDimmitt commented 5 years ago

@maisano, any bandwidth to look at this change?

maisano commented 5 years ago

@MichaelDimmitt sorry for the delay! I'll publish this as a minor later today.

jerrylow commented 5 years ago

@maisano sorry, is it possible to push the minor update?

maisano commented 5 years ago

Just published 1.4.0 which has this patch. Apologies for the delay!