search

maisano / react-router-transition

painless transitions built for react-router, powered by react-motion
http://maisano.github.io/react-router-transition/
MIT License
2.59k stars 139 forks source link

How about adding didLeave callback to RouteTransition component? #86

Closed wgundamj44 closed 6 years ago

wgundamj44 commented 6 years ago

I have a use case where some actions need to be triggered when route transition is done.

However, current implementation doesn't support passing didLeave callback to underlying TransitionMotion. So how about add didLeave as a new property to RouteTranstion component?

maisano commented 6 years ago

hi @wgundamj44! does a downstream componentWillUnmount not work for that use case?

either way i could see this being useful. would you like to give the implementation a go?

maisano commented 6 years ago

@wgundamj44 just published version 1.2.0, which contains your changes. thanks again for the PR!