maistra / istio

Apache License 2.0
94 stars 92 forks source link

[release 2.5.2] OSSM-6035 mod: update to protobuf v1.33 #1010

Closed yxun closed 3 months ago

yxun commented 3 months ago

Please provide a description of this PR:

Related upstream PRs: https://github.com/istio/istio/pull/49733 https://github.com/istio/istio/pull/49815

They were merged in upstream Istio 1.21

This PR target branch is releases/2.5.2 . I will create a cherry pick PR later to maistra-2.5 branch

To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

Please check any characteristics that apply to this pull request.

yxun commented 3 months ago

The fix was merged in upstream Istio 1.21 . when we have our 2.6 , we also need to cherry pick this change.

yxun commented 3 months ago

/cherry-pick maistra-2.5

openshift-cherrypick-robot commented 3 months ago

@yxun: once the present PR merges, I will cherry-pick it on top of maistra-2.5 in a new PR and assign it to you.

In response to [this](https://github.com/maistra/istio/pull/1010#issuecomment-2139550183): >/cherry-pick maistra-2.5 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
yxun commented 3 months ago

/cherry-pick cancel

openshift-cherrypick-robot commented 3 months ago

@yxun: once the present PR merges, I will cherry-pick it on top of cancel in a new PR and assign it to you.

In response to [this](https://github.com/maistra/istio/pull/1010#issuecomment-2139570734): >/cherry-pick cancel Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.