search

maistra / istio

Apache License 2.0
94 stars 92 forks source link

[maistra-2.5] OSSM-6035 mod: update to protobuf v1.33 #1011

Closed yxun closed 3 months ago

yxun commented 3 months ago

Please provide a description of this PR:

Related upstream PRs: https://github.com/istio/istio/pull/49733 https://github.com/istio/istio/pull/49815

They were merged in upstream Istio 1.21

The fix was merged in upstream Istio 1.21 . when we have our 2.6 , we also need to cherry pick this change.

To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

Please check any characteristics that apply to this pull request.

yxun commented 3 months ago

Need to cherry-pick to releases/2.5.2 and maistra-2.6 later

yxun commented 3 months ago

/cherry-pick releases/2.5.2

openshift-cherrypick-robot commented 3 months ago

@yxun: once the present PR merges, I will cherry-pick it on top of releases/2.5.2 in a new PR and assign it to you.

In response to [this](https://github.com/maistra/istio/pull/1011#issuecomment-2139780141): >/cherry-pick releases/2.5.2 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-cherrypick-robot commented 3 months ago

@yxun: new pull request created: #1012

In response to [this](https://github.com/maistra/istio/pull/1011#issuecomment-2139780141): >/cherry-pick releases/2.5.2 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.