Closed yannuil closed 2 months ago
@jewertow as you suggest in the reverted commit, we don't want to include the fix in the Z-stream. This is a Y-stream. Should we include it?
/retest
No, we do not want that change at all.
I have dropped a commit to resolve the conflict with #1002. The commit was picked from istio/istio#48056, which includes some changes on pilot/pkg/config/kube/gateway/conditions.go
. Do we need to incorporate them as well? @jewertow @eoinfennessy
I have dropped a commit to resolve the conflict with #1002. The commit was picked from istio/istio#48056, which includes some changes on
pilot/pkg/config/kube/gateway/conditions.go
. Do we need to incorporate them as well?
Yes, I think we should incorporate the changes in conditions.go
. You may be able to use the controllerName
variable defined in model.go
.
/retest-required
/test maistra-istio-unit-2-6
/test maistra-istio-unit-2-6
/test maistra-istio-unit-2-6
/test maistra-istio-unit-2-6
@yannuil: No presubmit jobs available for maistra/istio@maistra-2.6
/test maistra-istio-unit-2-6
/test maistra-istio-unit-2-6
/retest-required
Do we want tide/merge-method-rebase
on this PR?
@eoinfennessy yes, we do.
/retest