maistra / istio

Apache License 2.0
94 stars 92 forks source link

OSSM-6615 Make sure IOR ignores services without selectors #1029

Closed luksa closed 2 months ago

luksa commented 2 months ago

Cherry-pick of #1022

IOR finds a matching service for a pod by checking each service's label selector. However, this also matches services with an empty selector, which is wrong. These services should be ignored by IOR since an empty label selector indicates that the service endpoints are managed externally and not that the service should match all pods.

The previous timeout was only 3s, which caused the retry.UntilSuccessOrFail to fail on the first attempt instead of allowing the retry to be performed.

luksa commented 2 months ago

/retest