search

maistra / maistra.github.io

This is the source for maistra.io.
http://www.maistra.io
Apache License 2.0
13 stars 29 forks source link

[MAISTRA-1744] Route Annotations Documentation Update #158

Closed David-Elizondo closed 4 years ago

David-Elizondo commented 4 years ago

Adding documentation in reference to propagating route annotations in IOR. Feature will be added from these PRs:

Version 1.1: https://github.com/maistra/ior/pull/11 Version 2.0: https://github.com/maistra/istio/pull/158

https://issues.redhat.com/browse/MAISTRA-1744

maistra-bot commented 4 years ago

Hi @rtselizondo. Thanks for your PR.

I'm waiting for a maistra member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
brian-avery commented 4 years ago

/retest

brian-avery commented 4 years ago

That failure is being fixed in https://github.com/maistra/maistra.github.io/pull/161.

brian-avery commented 4 years ago

/retest

maistra-bot commented 4 years ago

@rtselizondo: you cannot LGTM your own PR.

In response to [this](https://github.com/maistra/maistra.github.io/pull/158#discussion_r469465321): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
brian-avery commented 4 years ago

/retest

brian-avery commented 4 years ago

/cherry-pick maistra-1.1

maistra-bot commented 4 years ago

@brian-avery: new pull request created: #162

In response to [this](https://github.com/maistra/maistra.github.io/pull/158#issuecomment-673190260): >/cherry-pick maistra-1.1 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.