Improve formatting for monitoring and tracing on non-wide screens.

maistra / maistra.github.io

This is the source for maistra.io.

http://www.maistra.io

Apache License 2.0

13 stars 29 forks source link

Improve formatting for monitoring and tracing on non-wide screens. #69

Closed kaovilai closed 5 years ago

kaovilai commented 5 years ago

See https://maistra.io/docs/monitoring_and_tracing/ If I expand the window a little it becomes centered as expected but still with a thick border surrounding. As opposed to the pages immediately following which displayed just fine on non-wide screens

dgn commented 5 years ago

Cannot reproduce this, but this is probably an issue with our theme: https://github.com/matcornic/hugo-theme-learn

brian-avery commented 5 years ago

I'm also unable to reproduce this and Maistra.io has gone through a lot of changes this sprint, so this is likely fixed. The listing of articles is something that Maistra does differently than the theme we're based off of.

kaovilai commented 5 years ago

@brian-avery Reproduced just now

kaovilai commented 5 years ago

Eitherway the content background color should be consistent between pages.

kaovilai commented 5 years ago

Most pages looks like But here is Examples and Monitoring and Tracing standing out with its unique background.

brian-avery commented 5 years ago

Ah. Sorry, misunderstood. Was thinking you were referring to the content overflow in the initial screenshot. This is how it looks on the 1.0 preview. Still has the gray background, but now it's separate per issue rather than being a big block on the screen.

While content looks like:

kaovilai commented 5 years ago

Ok I think this is more acceptable. This issue can close once the preview made it to main page. (Or now if more convenient)

brian-avery commented 5 years ago

Thanks @kaovilai. Will close now and this change will be live on Maistra.io as soon as we switch to the new branch.