Instructor Feedback - Week 15

[pawaitemadisoncollege]

Nice job keeping up with your project plan and time log. I know you've been working hard on your project and I'm really looking forward to seeing the final product.

• [ ] Be sure to add the list of technologies used in your project in the readme.md, a link to the deployed application and screenshots/links to videos of the working application. This will really help prospective employers with the details of your work in one place.
• [ ] Unit tests appear old/out of date and do not cover the current state of the application.
• [ ] To fully test entities, use .equals method on your entities to compare them, rather than comparing field by field: https://github.com/maitlandk90/VeteranHuntersHelping/blob/3ea565fc8157d8194e388a42cf7c887dc7d1df82/src/test/java/edu/matc/persistence/EquipmentDaoTest.java#L88-L90
• [ ] Javadoc missing - remember there's a plugin in to do much of this work for you.
• [ ] Replace entity-specific daos with the generic dao to eliminate redundancy. This might provide inspiration: https://github.com/MadJavaEntFall2018/FatBikeTrailReports/blob/master/src/main/java/com/paulawaite/fbtr/persistence/GenericDao.java
• [ ] Is SignIn controller still used/necessary? Tomcat auth should be handling much of this?
• [ ] Another approach to this may be to put the id in the request as an attribute (request.setAttribute): https://github.com/maitlandk90/VeteranHuntersHelping/blob/3ea565fc8157d8194e388a42cf7c887dc7d1df82/src/main/java/edu.matc/controller/sendMessage.java#L46
• [ ] Review code for duplicate lines of code such as https://github.com/maitlandk90/VeteranHuntersHelping/blob/3ea565fc8157d8194e388a42cf7c887dc7d1df82/src/main/java/edu.matc/controller/sendMessage.java#L46, and refactor to eliminate redundancy.
• [ ] Review naming standards and update to meet standards. For example: class signUp should be class SignUp
• [ ] signUp class has a lot of nested logic, how might this be refactored for maintainability, readability?
• [ ] What is the user experience when something goes wrong, i.e., the database is down? Custom error page/s can help with this.