search

maitrungduc1410 / primeng-shadowdom-directives

Directives that make PrimeNG plays nicely with ShadowDOM
https://maitrungduc1410.github.io/primeng-shadowdom-directives/
MIT License
9 stars 3 forks source link

psdoverlaypanel Directive not functioning #15

Open karim-mamdouh opened 5 months ago

karim-mamdouh commented 5 months ago

Hello,

Please find the video below for issue

https://github.com/maitrungduc1410/primeng-shadowdom-directives/assets/79006178/619e06c5-5bc9-4b1f-8026-dab8e95e5617

Versions:

"@angular/animations": "~16.1.0", "@angular/common": "~16.1.0", "@angular/compiler": "~16.1.0", "@angular/core": "~16.1.0", "primeng": "^16.0.2", "primeng-shadowdom-directives": "^1.0.1",

maitrungduc1410 commented 5 months ago

Thanks for reporting issue, I'll check this and get back to you soon

karim-mamdouh-cin commented 5 months ago

Actually I found a way to fix it, I added the button as target for the toggle functions & then it worked perfectly

image

maitrungduc1410 commented 5 months ago

It's weird that you have to specify the target.

In this case the target can be ignored because for second parameter it'll default to event.target which is equal to #target here.

image

Can you check the demo app of this lib, in there I have examples for all cases

But yes, can go with your way first. I'll do some test this weekend.

maitrungduc1410 commented 5 months ago

Btw, can you check package-lock and provide exact version for all related dependencies? Then I'll just use the same

maitrungduc1410 commented 4 months ago

I checked, it's working really fine with same dependencies as you, maybe you should try create a fresh new screen/component and add the overlay to test, try to not apply any class/style during testing:

https://github.com/maitrungduc1410/primeng-shadowdom-directives/assets/16630193/ecf454c3-590f-4217-a2e2-a7903852663e