search

maitrungduc1410 / react-native-video-trim

Video trimmer for React Native App
MIT License
37 stars 14 forks source link

Trimming convert video to audio #14

Closed ronakbuoyancy closed 5 months ago

ronakbuoyancy commented 6 months ago

For some video, Trimming is not working if video trim for initial seconds. It's corrupted or convert to video to audio. It's happened only for compressed video like whatsApp compress video which is small size. I attached sample video, trim from initial 2 seconds and save it and check video output

https://github.com/maitrungduc1410/react-native-video-trim/assets/102415580/87d3ed71-d975-4687-a34b-83032e2153a6

Platform : Android "react-native": "^0.72.5", "react-native-video-trim": "^1.0.4", "node":"18.17.1"

maitrungduc1410 commented 6 months ago

sorry I missed your comment. Can I check options of your showEditor?

And which platform you face this error? ios or android?

maitrungduc1410 commented 6 months ago

I check with your video (Trim from 00:03, 3 seconds from start), it's fine, I'm using real device Xiami Redmi 8A, Android 9 API 28.

This is my options:

showEditor(result.assets![0]?.uri || '', {
  maxDuration: 20,
})

https://github.com/maitrungduc1410/react-native-video-trim/assets/16630193/820aea75-226d-46b6-8028-116862e9ac13

maitrungduc1410 commented 5 months ago

please upgrade to 1.0.8 and check again