maitrungduc1410 / react-native-video-trim

Video trimmer for React Native App
MIT License
37 stars 14 forks source link

Video size 360x640 #25

Closed sn4f closed 3 months ago

sn4f commented 4 months ago

Hello, by default this package is resizing input video after trimming. Is it possible to change quality? Currently all my output videos have 360x640px?

edit: I tried without a trimmer and all is good. Example video https://streamable.com/rii125

maitrungduc1410 commented 4 months ago

Hi, on iOS it's already set to High Quality: https://github.com/maitrungduc1410/react-native-video-trim/blob/master/ios/VideoTrim.swift#L57

And on my end I don't see this issue? Can you please check again?

sn4f commented 4 months ago

Hello, yes I tried all variants from their documentation and typeIFrame1280x720 is the best for now but still video is blurred.

sn4f commented 4 months ago

To specify my issue, when trimming the video, it remains in perfect quality, but after the trimming, the output I receive is blurry. I've tried this with several different files and formats (mov, mp4).

maitrungduc1410 commented 4 months ago

Hi,is it possible for you to provide some sample videos + respective generated outputs?

sn4f commented 4 months ago

Hi,is it possible for you to provide some sample videos + respective generated outputs?

Of course, here is a record + output file https://file.io/SaqW3VP3kUKx

EuSet commented 4 months ago

faced the same problem. quality is getting visibly worse after trimming

maitrungduc1410 commented 4 months ago

Hi @EuSet isue happens on ios right?

sn4f commented 4 months ago

If I may, it's only on iOS. Android looks good

maitrungduc1410 commented 4 months ago

I think I need some rework on iOS instead of relying on UIVideoEditorController which is out of my control

maitrungduc1410 commented 3 months ago

Hi @sn4f @EuSet , please upgrade to 1.0.12, remember to re-run pod install

iOS version is re-written from scratch, and the issue with video quality is solved.

output file will have same metadata as input file, quality is kept same

EuSet commented 3 months ago

Looks awesome!

sn4f commented 3 months ago

@maitrungduc1410 thank you so much for your quick help in this matter. All the best.