[Feature Request | Bug] Ensure Video File Readiness Within `showEditor()` Before Saving

anonymousDog12 commented 3 months ago

Greetings~

Issue Description

When invoking showEditor(), if I press the save button immediately after the editor opens, then the trimmed video often turns out to be corrupted
Conversely, if I allow some time to elapse before pressing save, the video is trimmed correctly without any issues.

Potential Cause and Suggested Solution

I am guessing the corruption is caused by attempting to save / start trimming videos before the original videos are fully loaded, but the UI lacks indicators to show if the file is ready.
So would it be possible to implement a check, or a "loading icon" to ensure file is fully loaded, before user can save and trim can happen?

Thank you for investigating the issue and considering this suggestion!

P.S. this is the video file I used for testing.

https://github.com/maitrungduc1410/react-native-video-trim/assets/27938057/96e2b4d1-3126-4d16-959f-b41a26d7db98

maitrungduc1410 commented 3 months ago

Great suggestion, I'll add this in next release.

Thank you 🙏

maitrungduc1410 commented 2 months ago

hi @ChangyuYan on which platform did you encounter the issue?

I just reviewed my code, actually the readiness of the video player should not affect the trimming process, because the process is based on the video URL, so even the player is not ready yet, but the URL is already there and known by the trimmer

What I'm trying to say is, whether the video player is ready or not, it doesn't matter

anonymousDog12 commented 1 month ago

Thank you for your updates, @maitrungduc1410 🙏

maitrungduc1410 / react-native-video-trim

[Feature Request | Bug] Ensure Video File Readiness Within `showEditor()` Before Saving #36

Issue Description

Potential Cause and Suggested Solution