search

maitrungduc1410 / react-native-video-trim

Video trimmer for React Native App
MIT License
37 stars 14 forks source link

Full Background Not Covered in iPhone 15 Pro Max #43

Closed shiyansiva closed 1 month ago

shiyansiva commented 1 month ago

@maitrungduc1410 When I open it, the video trim screen doesn't fully cover the background. Is there a way to make it cover the whole background?

IMG_0494

Once Again Thank you very much for making awesome library!

maitrungduc1410 commented 1 month ago

@shiyansiva this is completely controlled by UIVideoPlayerController from the platform.

It's based on your video dimension and determines how to show.

and from my point of view: your video is landscape, it's not good if you make it fullscreen

shiyansiva commented 1 month ago

@shiyansiva this is completely controlled by UIVideoPlayerController from the platform.

It's based on your video dimension and determines how to show.

and from my point of view: your video is landscape, it's not good if you make it fullscreen

@maitrungduc1410 I just want to make the modal taller, not change the video. The top of the video trim modal isn't covering the content behind it.

maitrungduc1410 commented 1 month ago

I'll push an update for this

maitrungduc1410 commented 1 month ago

@shiyansiva pls upgrade to 1.0.18, added fullScreenModalIOS

showEditor(url, {
  fullScreenModalIOS: true,
})
shiyansiva commented 1 month ago

@shiyansiva pls upgrade to 1.0.18, added fullScreenModalIOS

showEditor(url, {
  fullScreenModalIOS: true,
})

Sure, Thanks much🙌 @maitrungduc1410