maitrungduc1410 / react-native-video-trim

Video trimmer for React Native App
MIT License
37 stars 14 forks source link

Android 11 support request. #7

Closed yousafConovo closed 8 months ago

yousafConovo commented 8 months ago

This package does not support android 11 at the moment. Event if i remove WRITE_EXTERNAL_STORAGE permission from showEditor function the video is not being saved to device.

maitrungduc1410 commented 8 months ago

can you elaborate what exactly the issue you're facing?

This This package does not support android 11 at the moment, or this the video is not being saved to device?

yousafConovo commented 8 months ago

I am getting file path on onFinishTrimming but it is not accessible.

maitrungduc1410 commented 8 months ago

I am getting file path on onFinishTrimming but it is not accessible.

what do you mean by "accessible"?

yousafConovo commented 8 months ago

In my app there is a user stories feature just like instagram. I need to trim the video if it's above a certain duration and send that video to react-native-video-player. after trimming the video file and passing the trimmed file path to react-native-video-player i get an error saying that the file is not accessible. But the same code is working perfectly fine on IOS. And if i re trim that video using react-native-video-trim i am getting this error. onError {"message": "File is not a valid video", "name": "onError"}

maitrungduc1410 commented 8 months ago

let me check on this and get back to you

maitrungduc1410 commented 8 months ago

I'm trying to reproduce your scenario but can't reproduce the issue.

yousafConovo commented 8 months ago

The issue was with video that had a space in their name. I ended up with a work around. I converted the video to base64 and wrote it to my application's folder with a new name that had no space in it and it worked.

shiyansiva commented 8 months ago

@yousafConovo Could you please share a piece of code that you used to solve this issue?