search

maitrungduc1410 / react-native-video-trim

Video trimmer for React Native App
MIT License
37 stars 14 forks source link

Modal was closed #8

Closed shiyansiva closed 8 months ago

shiyansiva commented 8 months ago

I encountered an issue When I open the showmodal from one modal page and then proceed to trim the video within the trimmer modal, both the trimmer modal and our existing modal page close simultaneously.

maitrungduc1410 commented 8 months ago

can you elaborate more?

like after finish trimming, both modals close at the same time?

shiyansiva commented 8 months ago

@maitrungduc1410 "Both modals refer to our existing modal page and the trimmer page. In our current setup, we have one modal page, and when we open the trimmer page from that modal, if I trim the video on the trimmer page, it automatically closes both the trimmer page and the parent page."

maitrungduc1410 commented 8 months ago

okay, I'll check this and get back to you

maitrungduc1410 commented 8 months ago

Hi @shiyansiva which platform you're facing this issue?

shiyansiva commented 8 months ago

Iphone 12 real device

maitrungduc1410 commented 8 months ago

hi @shiyansiva I fixed this issue, pls upgrade to 1.0.4

shiyansiva commented 8 months ago

@maitrungduc1410 Your help is greatly valued. The problem has been resolved, and everything is running smoothly as anticipated. 🙌

sanketappsimity commented 8 months ago

@maitrungduc1410 Your help is greatly valued. The problem has been resolved, and everything is running smoothly as anticipated. 🙌

Can you pls share a peace of code like how you are handling in ios as well as android cause in ios i am getting (File is not Valid) while i am passing url
so can you pls Past here how you are passing Url in ios from gallery like ios url path it would be really help full

thanks

maitrungduc1410 commented 8 months ago

Hi @sanketappsimity isValidVideo is used for local file only, at the moment you can't use it for remote file, I was considering to implement it, but if we do that then it'll need to download the file and do validation, and it seems too overhead.

You can check example app to see how I did in my local: https://github.com/maitrungduc1410/react-native-video-trim/tree/master/example

shiyansiva commented 8 months ago

@maitrungduc1410 Your help is greatly valued. The problem has been resolved, and everything is running smoothly as anticipated. 🙌

Can you pls share a peace of code like how you are handling in ios as well as android cause in ios i am getting (File is not Valid) while i am passing url so can you pls Past here how you are passing Url in ios from gallery like ios url path it would be really help full

thanks

Sure @sanketappsimity, Could you please attempt this on a real device? I encountered the same issue when using the simulator.