Trimming Process Does Not Generate Expected Video, Sometime Trimmer Modal Stays Open

[shiyansiva]

After using the trimming functionality, we've encountered several issues on Android devices.

Expected Behavior: After trimming, the application should generate the trimmed video as expected. The trimmer modal should close promptly when users click "Save" or "Cancel,"

Actual Behavior: Currently, the application is not generating the trimmed video as expected. It may be missing or not reflecting the intended edits. Sometimes, the trimmer modal does not close as expected. It remains open even after the user clicks the "proceed" button.

Environment: Android 13 (Real Device) Also tested on Android 11 and 12 with Emulator.

Additional Information: "react": "16.13.1" "react-native": "~0.63.4", "react-native-video-trim": "^1.0.4",

buildToolsVersion = "30.0.2" minSdkVersion = 21 compileSdkVersion = 30 targetSdkVersion = 33 kotlinVersion = '1.3.41'

[maitrungduc1410]

Can you listen for onError to see if any error is there?

[shiyansiva]

@maitrungduc1410 I'm not receiving any error messages. After examining the console, it seems that the event emitter wasn't triggered. My device is writing a zero-size file.

[maitrungduc1410]

hi @shiyansiva is this issue still happening?

If yes, is it possible for you to prepare a test repo with same dependencies so that I can try to reproduce?

[shiyansiva]

Hello, @maitrungduc1410. Yes, the issue still persists. I attempted to create a test repository with the same dependencies, but I encountered errors due to the extensive configuration in our project.

[shiyansiva]

@maitrungduc1410 Can you please use this repo

Page

[maitrungduc1410]

thanks @shiyansiva , I'll check

[shiyansiva]

thanks @shiyansiva , I'll check

@maitrungduc1410 Have you had time to check this repo

[maitrungduc1410]

Hi,

i've been trying to run your project, but keeps on facing issues:

• pod install failed

  

• run-android failed:

• I try to fix issue with android but it came with another issue

Can you help me do this:

• with your own project, the real one, try to run one more time on Android with Real device
• Open Android studio and make sure you can see your device there. Open Logcat and select your device to view its log
• run-android, and when you hit Proceed, pay attention closely to Logcat at the time the issue happens. Then send me your insights

[shiyansiva]

Hi,

i've been trying to run your project, but keeps on facing issues:

• pod install failed

• run-android failed:

• I try to fix issue with android but it came with another issue

Can you help me do this:

• with your own project, the real one, try to run one more time on Android with Real device
• Open Android studio and make sure you can see your device there. Open Logcat and select your device to view its log
• run-android, and when you hit Proceed, pay attention closely to Logcat at the time the issue happens. Then send me your insights

I haven't checked with iOS only run the Android with below commands

-> yarn install ->npx react-native run-android

[shiyansiva]

Hi @maitrungduc1410, After removing the yarn.lock file, I attempted to reinstall dependencies using yarn install and run the Android project with npx react-native run-android. Unfortunately, this resulted in an error. However, I managed to resolve the issue by creating a local.properties file within the Android folder and adding the following line, which points to the correct SDK path sdk.dir=/Users/sivakumar.m/Libr ary/Android/sdk. After making this adjustment, the project ran successfully. I haven't checked with iOS only run the Android, Can you remove the yarn.lock file, Please give it a try, and let me know if this solution works for you as well.

[shiyansiva]

Hi @maitrungduc1410 Have you encountered this build issue recently

[maitrungduc1410]

Hi @shiyansiva today,I'll try deleting package-lock and see if it works

[shiyansiva]

Hi @shiyansiva today,I'll try deleting package-lock and see if it works

Thanks @maitrungduc1410

[maitrungduc1410]

Hi @shiyansiva it's still throwing issue when run-android

[maitrungduc1410]

I think you just run your project on your machine and help me do this:

with your own project, the real one, try to run one more time on Android with Real device Open Android studio and make sure you can see your device there. Open Logcat and select your device to view its log run-android, and when you hit Proceed, pay attention closely to Logcat at the time the issue happens. Then send me your insights

[shiyansiva]

@maitrungduc1410 Can you please check this

[maitrungduc1410]

The above log showed with the issue? (Modal not closed issue?)

[shiyansiva]

The above log showed with the issue? (Modal not closed issue?)

No, the modal is closed now, but unfortunately, the Trimming Process did not generate the expected trimmed video

[maitrungduc1410]

Hi @shiyansiva please upgrade to ^1.0.8 and try again

[shiyansiva]

Hi @shiyansiva please upgrade to ^1.0.8 and try again

@maitrungduc1410 Thank you for your reply. I've verified with the latest versions(1.0.8 & 1.0.10), but unfortunately, I'm still encountering the same issue.

[maitrungduc1410]

Hi @shiyansiva you mean the build issue right?

Since I couldn't reproduce your issue, it's very hard to tell.

I think it's high chance because of your project config, project dependencies...

You can try with new project and see if it works

[shiyansiva]

Hi @shiyansiva you mean the build issue right?

Since I couldn't reproduce your issue, it's very hard to tell.

I think it's high chance because of your project config, project dependencies...

You can try with new project and see if it works

@maitrungduc1410 No , the Trimming Process did not generate the expected trimmed video (facing the issue only in android)

[maitrungduc1410]

Is it possible for you to provide a sample video?

Also your code?

[shiyansiva]

@maitrungduc1410 Please check this video https://github.com/maitrungduc1410/react-native-video-trim/assets/35214422/e4b1acf2-a8d0-4519-9967-032b0c75a394