maiuswong / simaware-express

SimAware on Express.js
Other
24 stars 38 forks source link

Tower, Ground and Delivery role not showing up in the APAC region. #101

Closed BokBoy closed 5 months ago

BokBoy commented 5 months ago

Hi all, I've been using Simaware for a while now and only recently noticed that the T, G and D roles are not showing up on Australia, even though it is online. The ATIS shows up, as you can see. I just flew into YSCB (image below) and the Tower was online but only the ATIS is showing up. This only affects T, G and D roles not Centre, Approach or Departures. image Thanks!!

BokBoy commented 5 months ago

Oh yeah, in console, I'm getting error - Patrons is not defined, if that helps Probably not related

BokBoy commented 5 months ago

Right, APAC region all use VATSYS, its a forced client by the division directors, and our callsigns aren't icao_twr or icao_gnd, its SY_GND or ML_TWR, depending on location

kenkam commented 5 months ago

Oh yeah, in console, I'm getting error - Patrons is not defined, if that helps

This is fixed in #99, although I think it is unrelated to your specific issue.

BokBoy commented 5 months ago

Oh yeah, in console, I'm getting error - Patrons is not defined, if that helps

This is fixed in #99, although I think it is unrelated to your specific issue.

Yea I'm thinking this isn't related but thought I may as well mention this.

AgentWolfFBI commented 5 months ago

Right, APAC region all use VATSYS, its a forced client by the division directors, and our callsigns aren't icao_twr or icao_gnd, its SY_GND or ML_TWR, depending on location As far as I'm aware, this is the reason why. As you said, SY_TWR as opposed to YSSY_TWR is causing issues, for example. VatSpy doesn't have this issue with aerodrome stations.

Another more complicated issue is extended FIR sectors in APAC, whereby a controller may extend their services to multiple sectors surrounding their primary sector. The only way for Simaware (& other VATSIM maps) to show the extended sectors as staffed would be to identify which frequencies are actively in use --- while extending, controllers cross-couple frequencies from multiple sectors. VATPAC has already written code to do this for their own coverage map; perhaps this could be integrated into SimAware at some point?

I think a far greater issue is the aerodrome stations though as this is a direct misrepresentation of coverage. I wouldn't consider myself an expert, however it doesn't seem to be a particularly complex issue to solve if it's simply the naming convention causing the problem.

BokBoy commented 5 months ago

Right, APAC region all use VATSYS, its a forced client by the division directors, and our callsigns aren't icao_twr or icao_gnd, its SY_GND or ML_TWR, depending on location As far as I'm aware, this is the reason why. As you said, SY_TWR as opposed to YSSY_TWR is causing issues, for example. VatSpy doesn't have this issue with aerodrome stations. Another more complicated issue is extended FIR sectors in APAC, whereby a controller may extend their services to multiple sectors surrounding their primary sector. The only way for Simaware (& other VATSIM maps) to show the extended sectors as staffed would be to identify which frequencies are actively in use --- while extending, controllers cross-couple frequencies from multiple sectors. VATPAC has already written code to do this for their own coverage map; perhaps this could be integrated into SimAware at some point?

Hmm... the first one could possibly be solved by checking the controller description as the controller normally puts - "extending to" then a list like ELW, BIK...

maiuswong commented 5 months ago

This may be fixed; the prefix was being pulled from an old airports.json and not the one that is updated nightly. Since it's 2AM over there I'll leave this open until it's confirmed fixed.

BokBoy commented 5 months ago

This may be fixed; the prefix was being pulled from an old airports.json and not the one that is updated nightly. Since it's 2AM over there I'll leave this open until it's confirmed fixed.

Good morning to you too. It is 2 am AEDT when you sent that. We can try this tonight (more like morning for Zulu time) as we have a milk run Monday at 0730-1130 Zulu. If it works, I'll send an update here. Thanks!!

Edit - fixed time, milk run starts 0730 not 0830.

BokBoy commented 5 months ago

Sadly not fixed image image

AgentWolfFBI commented 5 months ago

Hmm... the first one could possibly be solved by checking the controller description as the controller normally puts - "extending to" then a list like ELW, BIK...

Probably not feasible unfortunately. Most controllers include this (they should), but many don't. And the structure varies among those who do (e.g. some include the frequencies as well, others don't bother).

BokBoy commented 5 months ago

Hmm... the first one could possibly be solved by checking the controller description as the controller normally puts - "extending to" then a list like ELW, BIK...

Probably not feasible unfortunately. Most controllers include this (they should), but many don't. And the structure varies among those who do (e.g. some include the frequencies as well, others don't bother).

Most controllers do it... Noticed the frequency thing - just ignore it, the centers have dedicated frequencies that they just share. image

BokBoy commented 5 months ago

Uhh @maiuswong it randomly fixed on my end... Thanks for the help, I'm going to keep this open for the extending to part. Thanks!!

AgentWolfFBI commented 5 months ago

Uhh @maiuswong it randomly fixed on my end... Thanks for the help, I'm going to keep this open for the extending to part. Thanks!!

Still not fixed, but it's gone back to how it was a few months ago whereby it seems the major Class C aerodromes (Sydney, Mlebourne, etc) show up fine but not the rest. See attached screenshot VatSpy SimAware

Most controllers do it... Noticed the frequency thing - just ignore it, the centers have dedicated frequencies that they just share.

Even for those who do, there's no standard structure as demonstrated in your screenshot, so you'd have to write some sort of regex to parse the Controller Info and interpret what they've written. Even still, it just wouldn't work for the controllers who don't include it in their info (there's no actual VATPAC requirement for them to include this). Far easier to just use the currently opened frequencies to determine which sectors are staffed (as each sector has a corresponding frequency, and when extending controllers are required to couple the frequencies of the sectors they're extending to). This is how VATPAC's map works. I might speak to AJ (who works on the VATPAC map) about potentially adapting this code for SimAware.

BokBoy commented 5 months ago

Uhh @maiuswong it randomly fixed on my end... Thanks for the help, I'm going to keep this open for the extending to part. Thanks!!

Still not fixed, but it's gone back to how it was a few months ago whereby it seems the major Class C aerodromes (Sydney, Mlebourne, etc) show up fine but not the rest. See attached screenshot

VatSpy

SimAware

I stand corrected, I was wondering why YWMW or whatever the ICAO was wasn't showing up, thought it was server lag or smth (flew to Sydney from Canberra on Vatsim just then)

BokBoy commented 5 months ago

Thanks mate will open new issue for the extending too one.