maiuswong / simaware-express

SimAware on Express.js
Other
24 stars 38 forks source link

Layers not working because of definitions #103

Closed ardayasar closed 5 months ago

ardayasar commented 5 months ago

Tried to reach website and couldn't see ATC layers. The problem has been from layers_positions. Couldn't assign because it was not declared before

Uncaught (in promise) ReferenceError: layers_positions is not defined findLayersPosition https://simaware.ca/js/simaware_app/app.js:1 refreshATC https://simaware.ca/js/simaware_app/app.js:1 each jQuery refreshATC https://simaware.ca/js/simaware_app/app.js:1

kenkam commented 5 months ago

Fixed by https://github.com/maiuswong/simaware-express/pull/104

FWIW it looks like this failure condition only occurs if you load the page on seconds 1, 16, 31, or 46, which will trigger a page refresh potentially before the app has been initialised.

maiuswong commented 5 months ago

Thanks @kenkam!