nus-se-bot
commented
4 months ago Team's Response
As specified by our UG section for this command (see attached below), the patient command takes any number of arguments which will be matched against all details of patient in the list (NRIC, name, dob, and phone). In your input right now, the keywords doctor, and 1234 are used to find patients. As intended, the system returns the two patients whose NRIC contains 1234.
Therefore, your command correctly searches through the list of patients who's details contain the substring you supplied (there could be an instance of someone who's name contains "doctor" as a substring).
Items for the Tester to Verify
:question: Issue response
Team chose [response.Rejected]
- [x] I disagree
Reason for disagreement: This was an actual issue that I faced while during the PE. 'patient' had already been there in the input line, probably from my previous commands, however I had intended for the command to be 'doctor 1234' and I was confused when the application returned patients as I was searching for doctors. I precautiously copied every command before entering during the PE so that I could refer back if there was an error and when seeing that I realised that the command had a 'patient' at the start and was searching patients instead. Hence I raised this as a bug as I felt that this is a very valid user behaviour and that it would benefit the user greatly if there could be a message saying that multiple command words were entered if they were to be of the exact same case as the command ('patient' and 'doctor') while if it was meant to be a keyword it could be anything as the finding command is already case-insensitive. I understand the point raised by the team, but this was an actual issue faced from the user side and not meant as a malicious input, again, hence my reason for raising it. As such I believe it to be a valid bug, but I agree that the severity of the bug could be reduced to Low as it is an issue that does not happen often.
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
When accidentally inputting a wrong command format, MediCLI still queries patients with 1234. This might be problematic as the user might have intended to query doctors instead.
Example: patient doctor 1234
It is expected that an error saying invalid format is shown, however patients are queried instead.