maize-genetics / phg_v2

Practical Haplotype Graph (PHG) version 2
https://phg.maizegenetics.net/
Apache License 2.0
21 stars 2 forks source link

Create fasta from hvcf fix duplicate entries #212

Closed lynnjo closed 2 months ago

lynnjo commented 2 months ago

Description

When creating a haplotype fasta from an hvcf file, there should not be duplicates. Fixed the code so that resulting fasta files will contain no more than 1 instance of a haplotype with its sequence.

Type of change

What type of changes does your code introduce? Put an x in boxes that apply.

Checklist:

Changelog entry

Please add a one-line changelog entry below. This will be copied to the changelog file during the release process.

CreateFastaFromHvcf now correctly contains a single instance of a haplotype sequence when when creating haplotype fastas.
codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.80%. Comparing base (89c340f) to head (56aa333). Report is 7 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #212 +/- ## ======================================= Coverage 82.80% 82.80% ======================================= Files 77 77 Lines 5054 5054 Branches 837 837 ======================================= Hits 4185 4185 Misses 557 557 Partials 312 312 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.