maize-genetics / phg_v2

Practical Haplotype Graph (PHG) version 2
https://phg.maizegenetics.net/
Apache License 2.0
21 stars 2 forks source link

Changed data structure in contextToRange(). Was rangeSampleToChecksum… #233

Closed tcasstevens closed 1 month ago

tcasstevens commented 1 month ago

… = Array<MutableList<String?>>(numberOfSamples()) { mutableListOf() }. Now rangeSampleToChecksum: MutableList<Array<String?>> = mutableListOf()

Description

Provide a summary of your changes including motivation and context. If these changes fix a bug or resolves a feature request, be sure to link to that issue.

Type of change

What type of changes does your code introduce? Put an x in boxes that apply.

Checklist:

Changelog entry

Please add a one-line changelog entry below. This will be copied to the changelog file during the release process.

Changed data structure in contextToRange(). Was rangeSampleToChecksum = Array<MutableList<String?>>(numberOfSamples()) { mutableListOf() }. Now rangeSampleToChecksum: MutableList<Array<String?>> = mutableListOf()
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 97.56098% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.48%. Comparing base (c850d84) to head (9ad96d8). Report is 23 commits behind head on main.

Files with missing lines Patch % Lines
...tlin/net/maizegenetics/phgv2/api/HaplotypeGraph.kt 97.56% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #233 +/- ## ========================================== + Coverage 81.40% 81.48% +0.08% ========================================== Files 81 81 Lines 5453 5488 +35 Branches 904 920 +16 ========================================== + Hits 4439 4472 +33 + Misses 678 675 -3 - Partials 336 341 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.