search

maizzle / framework

Quickly build HTML emails with Tailwind CSS.
https://maizzle.com
MIT License
1.2k stars 48 forks source link

PostHTML Expression config not used in render #1317

Closed Jordinateur closed 1 month ago

Jordinateur commented 1 month ago

Hi!

The expression configuration in build.expression, is not merged correctly just before rendering.

In my use case i want te remove locals scripts, and on the V5 nothing is removed. After some investigation i saw that the merge with the locals key in expression config was not done properly.

I added some test that you can check. Maybe you'll want this test not to be in the component loading test. Tell me if you want me to add a new test.

Thanks for your time once more.

cossssmin commented 1 month ago

Not seeing how this PR touches config merging, did you perhaps use the wrong branch? I see you just removed the code from your previous contribution. In any case, could you please rebase or re-create the PR, as I've updated the workflow config and we should now see PRs to the next branch being picked up by CI. Thanks!

Jordinateur commented 1 month ago

Sorry still not use to make PR. I'll make another one.

cossssmin commented 1 month ago

No worries, take your time :)

Just added a PR and CI is working as expected, so tests and linting will now run on any PR 👍