search

maizzle / framework

Quickly build HTML emails with Tailwind CSS.
https://maizzle.com
MIT License
1.2k stars 48 forks source link

Fix PostHTML expression config #1319

Closed Jordinateur closed 1 month ago

Jordinateur commented 1 month ago

Hi!

The expression configuration in build.expression, is not merged correctly just before rendering.

In my use case i want te remove locals scripts, and on the V5 nothing is removed. After some investigation i saw that the merge with the locals key in expression config was not done properly.

I added some test that you can check. Maybe you'll want this test not to be in the component loading test. Tell me if you want me to add a new test.

Thanks for your time once more.

cossssmin commented 1 month ago

Thanks, will have a look tomorrow. Is it ready or still working on it? I see you marked it as a draft.

Btw I should probably open an issue with known issues that I’ve run into while testing the beta (working on them) just in case so we don’t overlap.

Jordinateur commented 1 month ago

I will take a closer look tomorrow on it as well and let you know when I'm done with it.

And yeah do as want for the issue, I don't want to mess things up with your work.

cossssmin commented 1 month ago

Had another look and I think it's better to have a separate test and stub for this, yes.

Otherwise looks good👍

cossssmin commented 1 month ago

Went ahead and extracted the test and merged the PR, thanks for catching and fixing this!