search

maizzle / framework

Quickly build HTML emails with Tailwind CSS.
https://maizzle.com
MIT License
1.24k stars 49 forks source link

Production minification not working without customizing html-crush #307

Closed Sgouws closed 4 years ago

Sgouws commented 4 years ago

Adding the minify option to config.production.js does not minify the final code when building for production.

minify: {
    enabled: true,
  },

It requires that you customize your html-crush options before minification works. Perhaps I'm misinterpreting the docs, but my understanding is that adding that option should get minification working, albeit with defaults.

cossssmin commented 4 years ago

Indeed, removeLineBreaks is false by default in html-crush, so it won't minify unless you also manually set that to true.

Thanks for flagging this, I agree it should just work when you enable minifying. I'll add a PR that fixes this in a moment 👍