search

maj0-0 / pe

0 stars 0 forks source link

Unsure if model component cardinality matches actual implementation #11

Open maj0-0 opened 11 months ago

maj0-0 commented 11 months ago

image.png

If the address, priority and remark are optional, should it be 0...1 instead of 1?

nus-se-bot commented 11 months ago

Team's Response

Hi there, thanks for bringing this issue up.

As of the way we implemented the Address, Priority and Remark, each Person is always going to be associated to one of each classes mentioned above. A brief example would be, priority levels are differentiated using enums, and there will be Level.none, so even though there is no priority assigned to a Person from the user point of view, there will always be a Priority associated to the Person implementation-wise.

As class diagrams are not used to describe the problem domain, we think that it should match our implementation rather than the problem. Therefore, we decided to reject this bug as it is indeed a correct representation of our implementation.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]