Duplicate appointments are allowed after using markappt

[maj0-0]

Initial appointment

After marking the initial appointment, then adding the same appointment

Two appointments can be added for the same contact at the same time after being marked. I'm not sure how this would work as if one of the appointments is already done why would we need a duplicate one, at the same time and date. Very minor though! And unlikely to cause much harm outside of accidentally adding duplicate appointments and having no way of checking if you did.

[nus-se-bot]

Team's Response

Hi there, thank you for bringing up this issue.

Our response are as follows:

We agree that this is a severity.Low feature flaw. However, we do think that this feature flaw is NotInScope, due to the following reasons:

The modification required to fix this is non-trivial, in order to fix this in a proper way (i.e. not just abusing the use of throwing exceptions), it would require re-designing and overhauling the Appointment class to implement checks for past existing appointments and adding an AppointmentHistory class to each customer to keep track of each customer's detailed appointment history. Additionally, since our product's focus is first and foremost on being an addressbook for insurance agents and not to manage appointments, we decided to design in this iteration only, a supplementary basic appointment tracker that keeps of a customer's next appointment. We did not design our Appointment feature to be holistic and detailed in this iteration, hence omitting the ability to add multiple appointments to a customer as well as keep track of each customers' appointment history. Rather, we designed it to be minimalistic and bare-bones, having the essential functionality to help with assessing the priorities of the insurance agent. Since this feature would require a whole new functionality of an appointment history to detect duplicates, we want to postpone its development and assess the prioritisation of developing a fleshed-out appointment tracker.

We think that rather than putting in more time and effort into fixing this feature flaw in this iteration, the time spent on implementing and delivering other features is more important, as this flaw only causes minor inconvenience to users since:

• it is extremely unlikely that a user will add a duplicate appointment that has been marked(after manually marking an already completed appointment, it is extremely unlikely for the user to key it in again)
• even so, the user is extremely likely to remember that it has been completed, and delete the duplicate appointment after

  Items for the Tester to Verify

  :question: Issue response

Team chose [response.NotInScope]

• [ ] I disagree

Reason for disagreement: [replace this with your explanation]

---