search

majal / bible-linker-google-docs

A Google Documents Apps Script that searches for Bible verses and creates links to a selection of online Bible sources.
MIT License
8 stars 4 forks source link

added tagalog versions 'Edisyon sa Pag-aaral and 2019 Rebisyon' #20

Closed JerwellSavella closed 2 years ago

JerwellSavella commented 2 years ago

Modified to add Tagalog versions of the New World Translation of Holy Scriptures " 'Edisyon sa Pag-aaral' and as well the '2019 na Rebisyon' "

Signed-off-by: Jerwell Savella jerwellsavella@gmail.com

majal commented 2 years ago

Hi @JerwellSavella!

Thank you for creating a PR to add Tagalog NWT to main.

Last time we talked about this, @venjot and I agreed that to add languages, we will need to create modular code. He suggested JS classes to achieve this. We hope to have clearer code which makes it easier to add/remove/adjust languages instead of one long list of language-version pairs.

On the UI (menu) side, instead of all language-version pairs listed under Bible Linker > Choose Bible version > {version list}, we could maybe do a Bible Linker > Choose language and version > {language list} > {versions under this language}.

If you can collaborate with @venjot to design the next major revision of Bible Linker, it will be greatly appreciated. 🙂

In the meantime, others wanting TL (let's use ISO for languages) can copy your code and manually add your fork as a script.

JerwellSavella commented 2 years ago

I see, Thank you for the info Kuya @majal , I'll try to communicate with sir venjot, or will try to submit another PR next time and will implement interchangeable modules using JS classes to make it easier to modify the whole source, For now, I will just use my fork version whenever I needed the TL. Thank you po.

majal commented 2 years ago

Thanks @JerwellSavella! Sounds awesome. I'll close this PR for now. Looking forward to what you can create with @venjot. 🙂