search

majd / ipatool

Command-line tool that allows searching and downloading app packages (known as ipa files) from the iOS App Store
MIT License
5.35k stars 468 forks source link

Disable client timeout #157

Closed ViRb3 closed 1 year ago

ViRb3 commented 1 year ago

Having a client timeout of 15 seconds means that any IPA larger than that would fail to download. This limit is easily hit even at 1Gbit downlink. The DefaultTransport in Go already has sane connect, idle, handshake, keepalive timeouts, so IMO we can safely remove this one.

majd commented 1 year ago

I missed this when reviewing #155. Now that the internal HTTP client is used, we do need to set the timeout to 0. 👍