majek / puka

Puka - the opinionated RabbitMQ client
https://github.com/majek/puka
Other
182 stars 34 forks source link

Multi-ack support seems to be missing #59

Open vitaly-krugl opened 9 years ago

vitaly-krugl commented 9 years ago

basic_ack appears to lack support for the multiple option supported by RabbitMQ

majek commented 9 years ago

Is that a big deal?

vitaly-krugl commented 9 years ago

It's a performance issue, especially on higher-latency configurations

majek commented 9 years ago

There is some skeleton there, maybe adding that would not be hard: https://github.com/majek/puka/blob/master/puka/machine.py#L150

vitaly-krugl commented 9 years ago

Sure, that's probably one of the easier changes.

@majek, I am investigating alternatives to pika (due to licensing compatibility issues). Is puka being used in production now?

Many thanks, Vitaly