majensen / perlbolt

Neo4j server agent using Bolt protocol
Apache License 2.0
4 stars 2 forks source link

Mention unsupported EXPLAIN / PROFILE in docs #41

Closed johannessen closed 3 years ago

johannessen commented 3 years ago

Documenting the lack of support for EXPLAIN and PROFILE queries would allow us to close issues #7 and #8 as “wontfix“.

What do you think?

majensen commented 3 years ago

I think that's ok - but I guess it's just a matter of doing it? Does libneo4j-client need tweaking for it?

johannessen commented 3 years ago

This is just a proposed documentation patch declaring EXPLAIN and PROFILE to be unsupported, so that we can close those two issues.

Adding support for EXPLAIN and PROFILE to perlbolt would probably be possible without changes to libneo4j-client, but I’ve come to believe it isn’t worth the effort. 🙂 Your call!

johannessen commented 3 years ago

I’m confused … since you approved the changes, I can only assume you meant to merge them before closing the PR?

Addendum: I guess the “Merge” button isn’t green cause Travis failed. Makes it easy to miss. :-/