search

majestrate / XD

meme bittorrent client
https://xd-torrent.github.io/
MIT License
233 stars 25 forks source link

Tests fail to pass #113

Closed dbermond closed 4 months ago

dbermond commented 4 months ago

info

git revision / version: 0.4.5

OS: Arch Linux

Architecture: x86_64

problem

The tests fail to pass in version 0.4.5. They pass fine in version 0.4.4.

backtrace / error messages

Error messages: yes

$ make -C XD-0.4.5 test
make: Entering directory '/build/xd-torrent/src/XD-0.4.5'
go test ./...
# github.com/majestrate/XD/lib/bittorrent/swarm
# [github.com/majestrate/XD/lib/bittorrent/swarm]
lib/bittorrent/swarm/piece.go:28:3: github.com/majestrate/XD/lib/log.Errorf format % B has unknown verb B
?       github.com/majestrate/XD        [no test files]
?       github.com/majestrate/XD/cmd/rpc        [no test files]
?       github.com/majestrate/XD/cmd/xd [no test files]
?       github.com/majestrate/XD/lib/bittorrent [no test files]
?       github.com/majestrate/XD/lib/bittorrent/extensions      [no test files]
FAIL    github.com/majestrate/XD/lib/bittorrent/swarm [build failed]
?       github.com/majestrate/XD/lib/common     [no test files]
?       github.com/majestrate/XD/lib/config     [no test files]
?       github.com/majestrate/XD/lib/constants  [no test files]
?       github.com/majestrate/XD/lib/dht        [no test files]
?       github.com/majestrate/XD/lib/fs [no test files]
?       github.com/majestrate/XD/lib/gnutella   [no test files]
?       github.com/majestrate/XD/lib/log        [no test files]
?       github.com/majestrate/XD/lib/mktorrent  [no test files]
?       github.com/majestrate/XD/lib/network    [no test files]
?       github.com/majestrate/XD/lib/network/i2p        [no test files]
?       github.com/majestrate/XD/lib/network/inet       [no test files]
?       github.com/majestrate/XD/lib/rpc        [no test files]
?       github.com/majestrate/XD/lib/rpc/assets [no test files]
?       github.com/majestrate/XD/lib/rpc/transmission   [no test files]
?       github.com/majestrate/XD/lib/stats      [no test files]
?       github.com/majestrate/XD/lib/sync       [no test files]
?       github.com/majestrate/XD/lib/translate  [no test files]
?       github.com/majestrate/XD/lib/tracker    [no test files]
?       github.com/majestrate/XD/lib/version    [no test files]
ok      github.com/majestrate/XD/lib/configparser       0.024s
ok      github.com/majestrate/XD/lib/metainfo   0.003s
ok      github.com/majestrate/XD/lib/storage    0.008s
ok      github.com/majestrate/XD/lib/util       0.002s
FAIL
make: *** [Makefile:57: test] Error 1
make: Leaving directory '/build/xd-torrent/src/XD-0.4.5'

Backtrace: no

majestrate commented 4 months ago

try https://github.com/majestrate/XD/commit/ce6e0d9b26328f6c883c239e37045a3bc0496bf7

dbermond commented 4 months ago

try ce6e0d9

I can confirm that commit ce6e0d9b26328f6c883c239e37045a3bc0496bf7 fixes the tests.

Thank you for fixing this.